Do you use email encryption software? If so, your photo may not appear in the message after you click the Email button in iPhoto.
This issue only happens when using encryption software. It does not affect the actual attachment of the picture. When you send the message, the recipient will still receive the photo.