To resolve this issue, update to iPhoto 5.0.1 or later, and then rebuild your iPhoto Library. It's a good idea to make a backup copy of your iPhoto Library folder (located in your Pictures folder) before rebuilding it. To rebuild the library:
303473: iPhoto 6: Image appears when browsing but is blank or exclamation mark when editing